Make events not require sign-in #228
Conversation
This does not affect the theme color changes that are made to the theme-color thing after loading the page
SheepTester
requested review from
farisashai,
raymosun,
trevorkw7 and
alexzhang1618
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think this might be too big on mobile since there's essentially no relevant content to the events page above the fold. Maybe expandable login section with just an alert showing or smth smaller in general |
|
there's no way to get to the single |
|
If you click sign up from the events page login popup and then go back, it takes you from the /register page to the login page instead of the page you were previously on. I think this might have been hardcoded in initially |
|
You should hide the attended/not attended filter if the events page isn't logged in |
I'm not able to reproduce this for individual event pages
For /events, going to "Sign up" and back leaves me on the /register page but changes the URL to /events. I think this is due to a bug in the event's page's filtering implementation rather than the registration page
I would like to add "Events" to the navbar even when signed out. I think I'll do this in a separate PR after the store page also becomes public I think the current navbar implementation isn't great (has duplicate elements for mobile and desktop; has a hardcoded height; uses signed-out navbar on 404 pages) so I'd like to refactor it in a separate PR, along with adding events and store for the logged out navbar
I think the size is fine. We'd rather people stay logged in so we should try to pester them to log in, and it's easy to scroll past anyways |
because they're used for more than just signing in Cherry picked from e75f2c0; accidentally committed to wrong branch
…ship-portal-ui-v2 into sean/public-event
Info
there's no issue for this
event pages now no longer require login (because the API never required it). this way, you can send links to the events in Discord and it'll show the event cover bigly
however, to encourage people to sign up, these pages have a massive banner telling people to log in. the login form is embedded so you can just click log in if you have a password saved
there are otherwise no changes to the user's experience when signed in
Changes
withAccessTypepasses it the auth token (since it already reads it from the cookie)Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*and commented hard to understand areasanywhere else.
Screenshots
i also fixed the blue (for some reason Discord parses
#fffas#00f, oof)